-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding noEmit: true
is a breaking change and should be a major release version
#29
Comments
@sodatea can I get your thoughts on this? |
Technically this library is still zerover, so any minor version bump could be breaking. |
It's been |
In practice, 0.4.0 -> 0.5.0 is considered a major release that can contain breaking changes. |
Agree that it is opinionated.
IMO that's the point of the defaults. |
This wasn't flagged as a major release, based on the commit message: feat: turn on noEmit by default and add tsconfig.lib.json I think the issue is that this change makes the assumption that the developer's use-case is a "non-library project." This change makes it confusing for any developer that is new to Vue, using the standard configuration provided, to create a Vue component library without having to understand why their package isn't emitting the proper type declarations. We can close the issue (and I really appreciate you taking a look). Can I suggest the README be updated to explain the default |
Adding
noEmit: true
in #26 should be considered a breaking change and bump the major version.The comment added with the change, shown below, makes too many assumptions on when the tsconfig is extended and the behavior of the host application.
Even in the component libraries where we extend
@vue/tsconfig/tsconfig.json
, we have our own settings for exporting/generating types, etc. via flags that should not be overridden by this extendable configuration.IMO this change should be reverted as it is too opinionated.
The text was updated successfully, but these errors were encountered: