Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support virtual workspaces #2917

Open
lszomoru opened this issue May 7, 2021 · 7 comments
Open

Support virtual workspaces #2917

lszomoru opened this issue May 7, 2021 · 7 comments
Labels
feature-request integ:typescript lsp:general LSP integration for use in LSP clients

Comments

@lszomoru
Copy link

lszomoru commented May 7, 2021

馃憢 Hi there, Martin here, from the VS Code team.

Recently we've announced the Remote Repository feature that lets you browse and edit files and folders directly on GitHub.

Open Remote Repository... opens VSCode on a folder or workspace located on a virtual file system. We call this a virtual workspace. We observed that not all extension support this well, either because they can not, or they haven't thought about it.

It would be fantastic if you could test whether your extension can handle virtual workspaces:

Check out the Virtual Workspaces Extension Author Guide on how to do that.

When done, set the new virtualWorkspaces capability in your 'package.json'.

{
  "capabilities": {
    "virtualWorkspaces": true | false
  }
}
  • Use "virtualWorkspaces": true if your extension is prepared for virtual workspaces
  • Use "virtualWorkspaces": false if your extension should be disabled when a virtual workspace is opened

For questions and comments please use the Virtual Workspaces Tracking Issue.

Thanks for the support and the great work! 鉂わ笍

@yoyo930021 yoyo930021 added feature-request lsp:general LSP integration for use in LSP clients integ:typescript labels May 8, 2021
@nicooprat
Copy link

I think that's why we can't use Vetur anymore when using Live Share, so we can't pair program for a month in my team... Any chance to see this resolved soon? 馃檹

@oeg8168
Copy link

oeg8168 commented Jun 16, 2021

@nicooprat

I think that's why we can't use Vetur anymore when using Live Share, so we can't pair program for a month in my team... Any chance to see this resolved soon? 馃檹

In our team, we face the same issue as well. So we downgrade VS Code to 1.15.2 and everything works perfect馃槑

@aeschli
Copy link

aeschli commented Jun 16, 2021

@nicooprat Is it just the syntax highlighting that's missing? Or what else doesn't work when in guest window?

@aeschli
Copy link

aeschli commented Jun 16, 2021

@nicooprat @oeg8168 Until Vetur has adopted this, you can set

        "extensions.supportVirtualWorkspaces": {
            "octref.vetur": true
        }     

For vetur to run, you also need to trust the workspace.

@nicooprat
Copy link

Thanks @aeschli it works! To be precise, the user joining the session must have this in their local settings, not the host.

The trust permission is about the latest update so be sure to update before:

image

https://code.visualstudio.com/updates/v1_57#_workspace-trust

@yoyo930021
Copy link
Member

We will wait and see this feature.

  1. LSP isn't supported it. Ref
  2. TypeScript language service isn't support it too?

@aeschli
Copy link

aeschli commented Oct 17, 2021

Typescript provides limited support that is basically just looking at the current file and knows a set of bundled libraries.

For vue it would be great to at least get the grammars when in a virtual workspace.
For that, the best solution would be to extract a simple language extension that contains the language definition and the grammars. That will be useful as well for untrusted workspaces as well as when running as a web extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request integ:typescript lsp:general LSP integration for use in LSP clients
Projects
None yet
Development

No branches or pull requests

5 participants