Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chinese Version Document #1285

Closed
4 tasks done
buduan opened this issue Sep 5, 2022 · 7 comments
Closed
4 tasks done

Chinese Version Document #1285

buduan opened this issue Sep 5, 2022 · 7 comments
Labels
docs Improvements or additions to documentation enhancement New feature or request stale

Comments

@buduan
Copy link

buduan commented Sep 5, 2022

Is your feature request related to a problem? Please describe.

希望官方能出一套中文的文档,感谢

Describe the solution you'd like

希望官方能出一套中文的文档,感谢

Describe alternatives you've considered

No response

Additional context

No response

Validations

@brc-dd brc-dd added docs Improvements or additions to documentation enhancement New feature or request labels Sep 5, 2022
@awxiaoxian2020
Copy link
Collaborator

is PR welcome? @brc-dd

@brc-dd
Copy link
Member

brc-dd commented Nov 8, 2022

@awxiaoxian2020 I don't think we will be able to have both English and Chinese docs in this repo itself considering that i18n is not yet implemented. In future (after #1339 is merged) it might be possible to have both /en/ and /zh/ docs side by side here.

@awxiaoxian2020
Copy link
Collaborator

@awxiaoxian2020 I don't think we will be able to have both English and Chinese docs in this repo itself considering that i18n is not yet implemented. In future (after #1339 is merged) it might be possible to have both /en/ and /zh/ docs side by side here.

@brc-dd I think I can draft a pull request for /zh docs and be ready for review after #1339 done.

@awxiaoxian2020
Copy link
Collaborator

@buduan @dong-lufei you can review Chinese doc here.

@CHOYSEN
Copy link
Contributor

CHOYSEN commented Feb 8, 2023

Great idea, but I'm a little worried that after adding more translation languages in the future, the bundle time and size of the document itself will increase, and the issue/PR will be filled with trivial translation tasks. Can we consider dividing different languages into different repo for maintenance like vite :)

Vite: https://github.com/vitejs/docs-cn
Vue: https://github.com/vuejs-translations/docs-zh-cn

@awxiaoxian2020
Copy link
Collaborator

@CHOYSEN Please see vuejs-translations/docs-zh-cn#561
And @brc-dd I think we can close this issue now :)

@brc-dd brc-dd closed this as completed Jan 3, 2024
@brc-dd
Copy link
Member

brc-dd commented Jan 3, 2024

Yeah so in future, if there are many requests for different languages we can probably move them to separate repos in translations org, and give the contributors write access there. But for now, it seems fine to have Chinese translations here itself. Till now, I haven't seen requests for any other languages, and considering that the amount of contributors that understand Chinese is significant, I hope it won't be much of a burden to maintain. I'm not a Chinese speaker, so I'm mostly reviewing the PRs using translation tools and stuff. This might not result in top-notch quality for Chinese docs, but it should be fine as long as our Chinese users keep contributing.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs Improvements or additions to documentation enhancement New feature or request stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants