fix: mixed rgba colors for md code plugins #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matias-capeletto Thanks a lot! I think merging #142 made conflicts. Could you resolve this one 🙏 |
|
@kiaking should I do a PR porting the markdown extensions page from vuepress to vitepress docs so we can test these plugins? I think we could directly copy that page into vitepress docs. |
|
Oh yeah that would be great idea. Would you like to added it to this PR? |
|
Great, I'll look into it. If you do not mind, I prefer to send a new PR for the docs so we can close this one 👍 |
|
@matias-capeletto
Got ya. I'll merge this one for now. Please open another PR for the docs 🙌 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
rgba(0,0,0,50%)was working in dev but it was converted to an invalid colorrgba(0,0%,0%,50%)when building so the highlighted lines were not visibleSwitching to a number for alpha (as it is in other rgba values in the css) fixes the issue.
I do not know if
rgba(0,0,0,50%)is a valid color to be supported, I looked a bit and this conversion doesn't seem to be the responsibility of vitepress.