Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: dark/light mode transition duration for switch doesn't match page transition duration #1478

Closed
4 tasks done
kevinzunigacuellar opened this issue Oct 13, 2022 · 0 comments · Fixed by #1479
Closed
4 tasks done
Labels
bug: pending triage Maybe a bug, waiting for confirmation

Comments

@kevinzunigacuellar
Copy link
Contributor

Describe the bug

When switching between dark and light modes, the background color transition of the switch is longer than the rest of the page.

Recording

theme-flick.mov
  • I would like to submit a PR for this issue

Reproduction

  1. Go to VitePress
  2. Click on the dark/light mode switch multiple times
  3. Notice the flash between the background color of the switch with the rest of the page

Expected behavior

Screen.Recording.2022-10-13.at.17.59.54.mov

System Info

System:
    OS: macOS 12.6
    CPU: (8) arm64 Apple M1 Pro
    Memory: 542.95 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 18.10.0 - /opt/homebrew/bin/node
    npm: 8.19.2 - /opt/homebrew/bin/npm
  Browsers:
    Chrome: 106.0.5249.119
    Firefox: 105.0.3
    Safari: 16.0

Additional context

No response

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
@kevinzunigacuellar kevinzunigacuellar added the bug: pending triage Maybe a bug, waiting for confirmation label Oct 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug: pending triage Maybe a bug, waiting for confirmation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant