Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace node-diacritics in slugify function with a custom implementation #1553

Closed
4 tasks done
phenomen opened this issue Oct 29, 2022 · 1 comment · Fixed by #1554
Closed
4 tasks done

Replace node-diacritics in slugify function with a custom implementation #1553

phenomen opened this issue Oct 29, 2022 · 1 comment · Fixed by #1554
Labels
bug Something isn't working build Related to the build system

Comments

@phenomen
Copy link

Is your feature request related to a problem? Please describe.

@andrewrk/node-diacritics is a very outdated and unmaintained library. It has multiple major bugs that were never fixed.

Related issues:

Describe the solution you'd like

Most issues were fixed in vuepress by @larionov with a custom slugify implementation: vuejs/vuepress#1855

Describe alternatives you've considered

No response

Additional context

No response

Validations

@brc-dd
Copy link
Member

brc-dd commented Oct 29, 2022

Ah, we can directly import the slugify function from @mdit-vue/shared, it has the VuePress one.

@brc-dd brc-dd added bug Something isn't working build Related to the build system dependencies labels Oct 29, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working build Related to the build system
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants