Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

character (%20) in markdown filename cannot work after build #2296

Closed
3 tasks done
gyhyfj opened this issue Apr 26, 2023 · 2 comments
Closed
3 tasks done

character (%20) in markdown filename cannot work after build #2296

gyhyfj opened this issue Apr 26, 2023 · 2 comments
Labels
bug Something isn't working build Related to the build system

Comments

@gyhyfj
Copy link
Contributor

gyhyfj commented Apr 26, 2023

Describe the bug

For example:
If the markdown filename is 01 overview.md, and the link of this file in .vitepress/config.ts is link: 'path/to/01 overview' ,
then:

  1. If I run docs:dev, I can access this page by path/to/01%20overview, everything works well.
  2. If I run docs:build, it doesn't work, and return 404

Reproduction

As above

Expected behavior

blank character in markdown file's filename should still work after build

System Info

System:
    OS: Windows 10 10.0.19045
    CPU: (8) x64 Intel(R) Core(TM) i5-9300H CPU @ 2.40GHz
    Memory: 6.17 GB / 15.92 GB
  Binaries:
    Node: 18.16.0 - D:\Program Files\NodeJS\node.EXE
    npm: 9.6.4 - D:\Program Files\NodeJS\npm.CMD
  Browsers:
    Edge: Spartan (44.19041.1266.0), Chromium (112.0.1722.58)
    Internet Explorer: 11.0.19041.1566
  npmPackages:
    vitepress: latest => 1.0.0-alpha.74

Additional context

No response

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
@gyhyfj gyhyfj added the bug: pending triage Maybe a bug, waiting for confirmation label Apr 26, 2023
@kiaking kiaking added bug Something isn't working build Related to the build system and removed bug: pending triage Maybe a bug, waiting for confirmation labels Apr 27, 2023
@brc-dd
Copy link
Member

brc-dd commented Apr 27, 2023

IDK but having spaces in URLs seems like a pretty bad idea anyway 🤷‍♂️

@brc-dd
Copy link
Member

brc-dd commented Apr 30, 2023

Duplicate of #573

@brc-dd brc-dd marked this as a duplicate of #573 Apr 30, 2023
@brc-dd brc-dd closed this as not planned Won't fix, can't repro, duplicate, stale Apr 30, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working build Related to the build system
Projects
None yet
Development

No branches or pull requests

3 participants