Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: code groups scroll reset #2362

Closed
wants to merge 1 commit into from

Conversation

izayl
Copy link

@izayl izayl commented May 11, 2023

when code group tab is scrollable, click the label will cause the input focus, which is position at the lead of scroll position
this cause the strange behavior: click the label at offset position, and the tab scroll to lead

recurrence demo
vitepress-codegroup-scroll-issue-izayl.vercel.app/markdown-examples.html

2023-05-11.15.09.40.mov

@brc-dd
Copy link
Member

brc-dd commented May 18, 2023

This will break keyboard navigation. Users should be able to change tabs using arrow keys. Setting display: none removes those elements from the DOM and all related functionality.

@brc-dd brc-dd force-pushed the main branch 2 times, most recently from 7ad4a4e to f0d3082 Compare August 3, 2023 10:20
@brc-dd brc-dd closed this in 039798a Aug 5, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants