Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuration of minisearch to not split at - Sign (Hyphen, Minus) #2570

Closed
4 tasks done
gregorwolf opened this issue Jul 2, 2023 · 2 comments · Fixed by #2576
Closed
4 tasks done

Allow configuration of minisearch to not split at - Sign (Hyphen, Minus) #2570

gregorwolf opened this issue Jul 2, 2023 · 2 comments · Fixed by #2576
Labels
contribution welcome The team would welcome a contribution from the community for this issue enhancement New feature or request theme Related to the theme

Comments

@gregorwolf
Copy link

Is your feature request related to a problem? Please describe.

As described in How to search for items with an embedded hyphen? #108 minisearch does split by default at Hyphen/Minus Sign.

Describe the solution you'd like

It should be possible to influence this behaviour by defining a custom split variable.

Describe alternatives you've considered

No response

Additional context

No response

Validations
@brc-dd brc-dd added enhancement New feature or request theme Related to the theme contribution welcome The team would welcome a contribution from the community for this issue labels Jul 2, 2023
@zonemeen zonemeen mentioned this issue Jul 3, 2023
Merged
@gregorwolf
Copy link
Author

Thank you @zonemeen for the quick implementation and @brc-dd for the review and quick merge.

@gregorwolf gregorwolf mentioned this issue Jul 5, 2023
Closed
@gregorwolf
Copy link
Author

Feature request in the downstream project created: Configure VitePress search to not split at - Sign (Hyphen, Minus) #270

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
contribution welcome The team would welcome a contribution from the community for this issue enhancement New feature or request theme Related to the theme
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(search): support minisearch customization zonemeen/vitepress
2 participants
@gregorwolf @brc-dd