fix(theme): --vp-nav-height should be 0 when navbar is hidden #2575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buqiyuan
changed the title
brc-dd
reviewed
Jul 5, 2023
brc-dd
force-pushed
the
main
branch
2 times, most recently
from
7ad4a4e
to
f0d3082
Compare
|
In terms of design I'm not particularly a fan of this change, could add some spacing at the top (like 8 or 12px margin as nav height). |
|
yeah it should have some spacing. Can this be fixed if we use |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before：
after：
If this PR is merged, I will add document for it later.