Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Improve navbar blur styles #2751

Closed
4 tasks done
jd-solanki opened this issue Aug 8, 2023 · 4 comments · Fixed by #3359
Closed
4 tasks done

🎨 Improve navbar blur styles #2751

jd-solanki opened this issue Aug 8, 2023 · 4 comments · Fixed by #3359
Assignees
Labels
enhancement New feature or request theme Related to the theme

Comments

@jd-solanki
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Hi 👋🏻

We are now moving towards v1 and with the merge of #2727 I would like to purpose another change which makes VitePress more elegant.

ATM, navbar blur on scroll doesn't blend into the content purticularly when it's dark content like code block
image

If you notices there's thick line clearly separating the navbar and the content.

Describe the solution you'd like

Making it more smoother. I don't have words for this but I guess you know how it should look.

Describe alternatives you've considered

None

Additional context

none

Validations

@kiaking
Copy link
Member

kiaking commented Aug 8, 2023

Very good point. I do have some thoughts on global header on doc layout. I'm thinking maybe we should draw a gutter line... 🤔

Especially on Tablet view size when we have "On this page" outline button. I wanted make that one better but couldn't come up with good idea, but if we have clear divider at header, it's much easier.

I'll try to create mockup and gather some ideas.

@kiaking kiaking added enhancement New feature or request theme Related to the theme labels Aug 8, 2023
@jd-solanki
Copy link
Contributor Author

Hey @kiaking

Thanks for the positive response. As we have not released the v1 yet I would like to suggest some change to the layout if you agree.

It will be more natual, better & cleaner if we make the navbar full width like mintlify:
image

Benefits:

  • Make structure & code more simple (no padding hacks for sidebar)
  • allow separating docs in more chunks (sub-navbar) like docus (ex: nuxt's docs)
  • More cleaner if we adopt the border layout instead of shadow like mintlify (ex: our admin template)

I also did the same on my docs site if you want to check in VitePress: Anu Docs (I just hasn't enabled the blur yet)

What's your thoughts on this?

@elringus
Copy link

elringus commented Aug 8, 2023

It's pretty easy to customize (here is a sample: #2442 (comment)), but would nice to have something like that out of the box. Blur filter for this kind of stuff getting more popular lately.

@jd-solanki
Copy link
Contributor Author

🤦🏻‍♂️ This GH bots

@brc-dd brc-dd removed the stale label Sep 17, 2023
@github-actions github-actions bot added the stale label Oct 19, 2023
@kiaking kiaking self-assigned this Dec 19, 2023
@kiaking kiaking removed the stale label Dec 19, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request theme Related to the theme
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants