Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression in navbar (when upgrading from 1.0.0-beta.6 to 1.0.0-rc.4) #2796

Closed
4 tasks done
Fil opened this issue Aug 16, 2023 · 1 comment
Closed
4 tasks done

regression in navbar (when upgrading from 1.0.0-beta.6 to 1.0.0-rc.4) #2796

Fil opened this issue Aug 16, 2023 · 1 comment
Labels
bug Something isn't working theme Related to the theme

Comments

@Fil
Copy link

Fil commented Aug 16, 2023

Describe the bug

On https://observablehq.com/plot/ we tried to upgrade vitepress from 1.0.0-beta.6 to 1.0.0-rc.4, and noticed the following regression:

navbar does not always stay put when you click on one of its links; if a panel at the bottom was open, it may close and the link you have just clicked on moves up, making you lose track of where you were.

Here are two short clips that show the difference:

BEFORE (1.0.0-beta.6):
https://github.com/vuejs/vitepress/assets/7001/43778787-d21a-4c1e-b71c-71fad70512a0

AFTER (1.0.0-rc.4):
https://github.com/vuejs/vitepress/assets/7001/b7450b0f-07ca-4a2e-910c-db04eb1a18f6

Reproduction

run yarn docs:dev from observablehq/plot#1809

open the subnav tabs in the nav pane, click

Expected behavior

clicking on links in the nav pane should not close or open the subnav tabs.

System Info

System:
    OS: macOS 13.4.1
    CPU: (8) arm64 Apple M2
    Memory: 39.53 MB / 24.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.3.0 - ~/.nvm/versions/node/v20.3.0/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 9.6.7 - ~/.nvm/versions/node/v20.3.0/bin/npm
  Browsers:
    Chrome: 115.0.5790.170
    Safari: 16.5.1
  npmPackages:
    vitepress: ^1.0.0-rc.4 => 1.0.0-rc.4

Additional context

No response

Validations

@Fil Fil added the bug: pending triage Maybe a bug, waiting for confirmation label Aug 16, 2023
@brc-dd brc-dd added bug Something isn't working theme Related to the theme and removed bug: pending triage Maybe a bug, waiting for confirmation labels Aug 16, 2023
@brc-dd brc-dd closed this as completed in 33962e0 Aug 16, 2023
@Fil
Copy link
Author

Fil commented Aug 16, 2023

thank you, @brc-dd!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working theme Related to the theme
Projects
None yet
Development

No branches or pull requests

2 participants