fix: scroll-to-top in iOS when opens sidebar #2803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ios-scroll.mp4
Scrolling to the top of the document when clicking on the menu button to open the sidebar in iOS. It's a bug.
Since
body-scroll-lockhas not been maintained for a long time since version4.0.0-beta.0. I think it's possible to downgrade to version3.1.5as many developers using this library verified the feasibility in willmcpo/body-scroll-lock#237.Version
3.1.5has more weekly npm downloads than version4.0.0-beta.0.IOS version: 16.3
Browser: Safari