fix(theme): revert 79 to 179 in yellow-soft #2858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brc-dd
force-pushed
the
theme-yellow-soft
branch
from
0fd5dbb
to
b0cad91
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2797 introduced
--vp-c-yellow-softfor background yellow. In the dark theme this usesrgba(234, 179, 8, 0.16), but for the light theme it isrgba(234, 79, 8, 0.14). I believe that79is a typo and it should be179in both cases.I don't see anything in the description of that PR that suggests the change from
179to79was intentional. The new 'yellow' isn't actually yellow, despite the variable name.This yellow background is used in a couple of places, most notably for warning containers. The picture below shows the impact of my change on the warning containers: