Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): dropdown menu partially hidden by the homepage footer when it is too long #2904

Merged
merged 2 commits into from Sep 4, 2023

Conversation

zonemeen
Copy link
Collaborator

@zonemeen zonemeen commented Sep 4, 2023

fix #2900

And I remove an unused css variable --vp-z-index-layout-top.

@brc-dd
Copy link
Member

brc-dd commented Sep 4, 2023

Ah, --vp-z-index-layout-top is meant for custom banners. It isn't documented yet (#2071). Refer this: https://github.com/faker-js/faker/blob/next/docs/.vitepress/components/Banner.vue#L83.

The order should be this IMO:

  --vp-z-index-footer: 10;
  --vp-z-index-local-nav: 20;
  --vp-z-index-nav: 30;
  --vp-z-index-layout-top: 40;
  --vp-z-index-backdrop: 50;
  --vp-z-index-sidebar: 60;

@zonemeen
Copy link
Collaborator Author

zonemeen commented Sep 4, 2023

Ah, --vp-z-index-layout-top is meant for custom banners. It isn't documented yet (#2071). Refer this: https://github.com/faker-js/faker/blob/next/docs/.vitepress/components/Banner.vue#L83.

Ah, I didn't notice that. I'll reorder these css variables.

@brc-dd brc-dd merged commit a60f079 into vuejs:main Sep 4, 2023
7 checks passed
@zonemeen zonemeen deleted the fix/2900 branch September 4, 2023 07:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the bottom part is hidden when main nav's dropdown is scroll to the bottom in home page
2 participants