perf: overall prevention of duplicate rendering in localSearch

[zonemeen]

The cache should be defined outside of debouncedWatch, otherwise a new cache will be redefined every time when debouncedWatch is retriggered. It's a bit of a waste of performance.

[brc-dd]

This will work, but will also cause memory leaks and that cache will keep on growing. We probably should use LRU cache here with some max limit like 256 pages. Instead of using lru-cache (which adds up extra 15kB), IG we simply can do something like https://stackoverflow.com/a/46432113/11613622

[zonemeen]

Thanks for the advice. I'll change it later when I have time.

[zonemeen]

@brc-dd Nice work on the next step! There's also a bit of a question here about whether 16 cache entries would be a bit too few.

[brc-dd]

Ah, 16 here actually means 16 files in memory. So there will be like 16 maps having anchor to rendered html matching which will already be quite big. And I tested this on our docs, the cache misses were very few. On larger sites, that ratio might be slightly higher, but won't be there if the user is searching related stuff.

[zonemeen]

Ah, got it! 🤗