Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hover effects for links in footer #3178

Merged
merged 2 commits into from Nov 6, 2023
Merged

Add hover effects for links in footer #3178

merged 2 commits into from Nov 6, 2023
+10 −0

Conversation

akshaybabloo
Copy link
Contributor

This PR adds a dotted underline to anchor tags in footer with hover effect

closes #3171

kiaking
kiaking approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@kiaking kiaking left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense. I've modified a style to match other parts of the docs. Also, we need to use :deep in order to target v-html rendered tag (which I also updated) 👍

Screenshot 2023-11-06 at 21 01 54

@kiaking kiaking requested a review from brc-dd November 6, 2023 12:05
@brc-dd brc-dd merged commit a482611 into vuejs:main Nov 6, 2023
7 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kiaking kiaking kiaking approved these changes

@brc-dd brc-dd Awaiting requested review from brc-dd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Footer links should have an underline
3 participants
@akshaybabloo @kiaking @brc-dd