Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking internal links without .html pointing a directory now triggers non-SPA navigation #3225

Closed
4 tasks done
sapphi-red opened this issue Nov 19, 2023 · 0 comments
Closed
4 tasks done
Labels
bug: pending triage Maybe a bug, waiting for confirmation

Comments

@sapphi-red
Copy link
Contributor

Describe the bug

- [/example/](/example/) ❌
- [./example/](./example/) ❌
- [/example/index.md](/example/index.md) ❌
- [./example/index.md](./example/index.md) ❌
- the Left top "Vitepress" ❌
- Sidebar "example" ❌
- Navbar "example" ❌

Clicking these internal links now triggers non-SPA navigation.

related: https://vitepress.dev/guide/markdown#internal-links

Reproduction

https://stackblitz.com/edit/vite-tyiztl?file=docs%2Findex.md,docs%2F.vitepress%2Fconfig.ts

Expected behavior

SPA navigation happens like it does with 1.0.0-rc.27.

System Info

Stackblitz

  System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 18.18.0 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 9.4.2 - /usr/local/bin/npm
    pnpm: 8.10.0 - /usr/local/bin/pnpm
  npmPackages:
    vitepress: 1.0.0-rc.28 => 1.0.0-rc.28

Additional context

This bug seems to be caused by #3218

Validations

@sapphi-red sapphi-red added the bug: pending triage Maybe a bug, waiting for confirmation label Nov 19, 2023
@brc-dd brc-dd closed this as completed in d63cb86 Nov 19, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug: pending triage Maybe a bug, waiting for confirmation
Projects
None yet
Development

No branches or pull requests

1 participant