Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unneeded scrollbar in sidebar #3228

Closed
4 tasks done
patak-dev opened this issue Nov 20, 2023 · 3 comments
Closed
4 tasks done

Unneeded scrollbar in sidebar #3228

patak-dev opened this issue Nov 20, 2023 · 3 comments
Labels
theme Related to the theme

Comments

@patak-dev
Copy link
Member

Describe the bug

A scrollbar appears in the sidebar when it isn't required:
image

I saw the same in https://vitepress.dev

Reproduction

Run the vitepress dev docs.

Expected behavior

The sidebar shouldn't be there until there are enough items in the sidebar.

System Info

n/a

Additional context

There is a padding-bottom: 128px here that may be part of the issue. It seems the height of the sidebar should also be reviewed.

Validations

@patak-dev patak-dev added the bug: pending triage Maybe a bug, waiting for confirmation label Nov 20, 2023
@xiaodong2008
Copy link
Contributor

xiaodong2008 commented Nov 21, 2023

It seems like a style problem caused by padding.
I've tried to edit the padding at src/client/theme-default/components/VPSidebar.vue and this problem is solved.

@brc-dd brc-dd added theme Related to the theme and removed bug: pending triage Maybe a bug, waiting for confirmation labels Nov 22, 2023
@brc-dd brc-dd closed this as completed in ef6d8d1 Nov 22, 2023
@patak-dev
Copy link
Member Author

@brc-dd thanks for the fix! I checked removing that line before and it only seems to work for the vite docs. I think there is some extra spacing still around that makes the vitepress docs show the sidebar when it could be avoided

@brc-dd
Copy link
Member

brc-dd commented Nov 22, 2023

Ah yeah. We still have 64px extra padding at bottom. I guess that was intentional to avoid having to move mouse/finger at the bottom to click something. @kiaking might know better.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
theme Related to the theme
Projects
None yet
Development

No branches or pull requests

3 participants