Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme/i18n): support customizing dark mode switch titles #3311

Merged
merged 3 commits into from Dec 30, 2023

Conversation

mrcego
Copy link
Contributor

@mrcego mrcego commented Dec 9, 2023

For non-native English speaker, the dark mode switch titles weren't customizable like we can with the label. This PR fix this.

Related to #3215

@mrcego mrcego changed the title fix(ally): can customize dark mode switch titles now fix(ally): can now customize dark mode switch titles Dec 9, 2023
@brc-dd brc-dd self-assigned this Dec 27, 2023
@brc-dd brc-dd changed the title fix(ally): can now customize dark mode switch titles fix(theme/i18n): can now customize dark mode switch titles Dec 27, 2023
@brc-dd brc-dd changed the title fix(theme/i18n): can now customize dark mode switch titles fix(theme/i18n): support customizing dark mode switch titles Dec 27, 2023
@brc-dd brc-dd merged commit 50c9758 into vuejs:main Dec 30, 2023
7 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants