Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: GitHub-flavored alerts cannot be nested (with errors) #3512

Closed
4 tasks done
shigma opened this issue Jan 28, 2024 · 3 comments
Closed
4 tasks done

Bug: GitHub-flavored alerts cannot be nested (with errors) #3512

shigma opened this issue Jan 28, 2024 · 3 comments
Labels
build Related to the build system contribution welcome The team would welcome a contribution from the community for this issue enhancement New feature or request

Comments

@shigma
Copy link
Contributor

shigma commented Jan 28, 2024

Describe the bug

  • Blockquotes can be nested.
  • Custom blocks can be nested.
  • But GitHub-flavored alerts cannot (with errors).
> case 1
>
> > nested content

:::: tip
case 2

::: warning
nest content
:::
::::

> [!TIP]
> case 3
>
> > [!WARNING]
> > case 3

image

image

Reproduction

https://stackblitz.com/edit/vite-alzhrt?file=docs%2Fexample.md

Expected behavior

Render without errors.

System Info

N/A

Additional context

No response

Validations

@shigma shigma added the bug: pending triage Maybe a bug, waiting for confirmation label Jan 28, 2024
@brc-dd
Copy link
Member

brc-dd commented Feb 2, 2024

This isn't supported on GitHub either. We can avoid throwing error and just render blockquote though.

@brc-dd brc-dd added build Related to the build system and removed bug: pending triage Maybe a bug, waiting for confirmation labels Feb 2, 2024
@shigma
Copy link
Contributor Author

shigma commented Feb 2, 2024

I'm willing to have a try if you can accept this feature.

@brc-dd brc-dd added contribution welcome The team would welcome a contribution from the community for this issue enhancement New feature or request labels Feb 2, 2024
@meduzen
Copy link

meduzen commented Feb 3, 2024

FYI, and as GitHub doesn’t do it automatically, I’ve referenced this issue in discussion #3540.

@brc-dd brc-dd closed this as completed in 8f8a6fe Feb 3, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build Related to the build system contribution welcome The team would welcome a contribution from the community for this issue enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants