New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unresolved promises in ssr (#940) #1069

Merged

Akryum merged 1 commit into vuejs:v4 from javiertury:fix_unresolved_promises

Oct 15, 2020

Contributor

javiertury commented Oct 4, 2020

Fixes #940

After evaluating a few alternatives, this one performed reliably on all my components.

If onServerPrefetch the query is not enabled or prefetch is disabled, resolve firstResult
If start is cancelled and a firstResult is pending, resolve firstResult
If stop is called and firstResult is pending, resolve firstResult

The remaining cases are coverd with the old conditions.

If query returns an error and firstResult is pending, reject with firstReject
If query completes successfully and firstResult is pending, resolve firstResult


          fix: unresolved promises in ssr (vuejs#940)

2d4499d

Akryum merged commit 8a71443 into vuejs:v4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment