Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(composable): Clear previous error when recieving a result #1120

Merged
merged 2 commits into from Jul 4, 2021
Merged

fix(composable): Clear previous error when recieving a result #1120

merged 2 commits into from Jul 4, 2021

Conversation

yrd
Copy link
Contributor

@yrd yrd commented Dec 18, 2020

When receiving new results (either because pollIntervalis set or because .refetch() was called), any errors that were previously caught are kept in cache. This means that subsequent updates will always continue to see the last error, even if the latest response from the server was OK. This PR adresses that by explicitly clearing any existing errors before handling new results.

This should address #1119.

@yrd yrd marked this pull request as ready for review January 13, 2021 07:14
@Akryum Akryum changed the title Clear previous error when recieving a result fix(composable): Clear previous error when recieving a result Jul 4, 2021
@Akryum Akryum merged commit 689c284 into vuejs:v4 Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants