Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

false positive "new content popup" on docs site #4566

Closed
ghost opened this issue Sep 11, 2019 · 4 comments
Closed

false positive "new content popup" on docs site #4566

ghost opened this issue Sep 11, 2019 · 4 comments

Comments

@ghost
Copy link

ghost commented Sep 11, 2019

Reproduction link

https://cli.vuejs.org/config/

Environment info

Win 10, Chrome

Steps to reproduce

I always see the popup but i've just entered the site. I think there is an issue with service worker.
https://cli.vuejs.org/config/

What is expected?

Should not pop

What is actually happening?

pops

@LinusBorg
Copy link
Member

That works as expected. When you visit the site, the content buffered by the SW is served. After that, the newer files are downloaded, so now there's new content, and the message is shown.

@ghost
Copy link
Author

ghost commented Sep 11, 2019

@LinusBorg Thanks for explainig. Even though i feel some things doesn't feel right i can't explain further. Closing now.

@ghost ghost closed this as completed Sep 11, 2019
@ghost
Copy link
Author

ghost commented Nov 25, 2019

@LinusBorg Can this be prevented if used network first strategy?
I don't know why that popup annoys me so much.

@LinusBorg
Copy link
Member

I'm not particularly versed in that, no.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant