Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM dependencies #578

Closed
sharifzadesina opened this issue Sep 1, 2017 · 7 comments
Closed

NPM dependencies #578

sharifzadesina opened this issue Sep 1, 2017 · 7 comments

Comments

@sharifzadesina
Copy link

sharifzadesina commented Sep 1, 2017

Why we can't have any NPM dependency in our custom template? I think this feature is required.

@LinusBorg
Copy link
Member

Your question is not clear, can you provide more details?

@sharifzadesina
Copy link
Author

sharifzadesina commented Sep 1, 2017

@LinusBorg this is not question, this is almost requesting a required feature.
See this repo: https://github.com/elegantweb/nwjs-vue
Try to install it using vue init elegantweb/nwjs-vue
You will see it says: string module not found or something similar.
This is cause we can't have any npm dependency in our package.json file this means vue-cli doesn't run npm install over template.

@posva
Copy link
Member

posva commented Sep 1, 2017

He wants to use custom packages in the meta.js https://github.com/elegantweb/nwjs-vue/blob/master/meta.js#L1

I remember it was for security reasons. We don't want a malicious template to mess up someone's computer because of a package they require

@sharifzadesina
Copy link
Author

@posva Yes, exactly, but security reasons? really?
1- If anyone wants to mess up, he can do even with pure node.
2- I don't think people will run vue with administration privileges (sudo).
So the security is not good reason at all.

@posva
Copy link
Member

posva commented Sep 1, 2017

😆 never make assumptions about what people will or will not do in security. People will always do what you expect less, especially dumb things like running a command with sudo when they shouldn't

@sharifzadesina
Copy link
Author

@posva Yes, but security reason doesn't work here :D I think we have to add this feature, this is required.

@posva
Copy link
Member

posva commented Sep 18, 2017

We'll come up with something for next version (see #589 ), but the current model of vue-cli makes this not secure

@posva posva closed this as completed Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants