Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: modify shortcut and add tooltips #1598

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Conversation

konpeki622
Copy link
Contributor

According to #1532 and #1281 , I try to make some modifications. Shortcut of filter components was changed from Ctrl + F to Alt + F. After select a component, we can press Alt + D to filter state. The same time related tooltip was added.

@Akryum Akryum merged commit d375c50 into vuejs:main Nov 23, 2021
@konpeki622 konpeki622 deleted the feat/shortcut branch November 24, 2021 01:45
@dkjain
Copy link

dkjain commented Apr 20, 2022

@Akryum These new shortcuts Alt + F and Alt + D overlaps with Chrome's shortcuts mean, if Filter State input box is focused (Alt + D) and getting focus Filter component input (Alt + F), chromes three vertical dot menu (towards top-right) button/trigger steals focus. And same when filter component input is focused (Alt + F) and now trying to focus filter state input (Alt + D), chrome's omnibar gets focused.

Pls test it.

@dkjain
Copy link

dkjain commented Apr 20, 2022

@Akryum Is it possible to provide a shortcuts editor for users to set shortcut to their preferences? Irrespective if this is possible or not, the current shortcuts overlaps with Chromes shortcuts and will need to be changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants