fix: generated app id not deduped #1719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akryum
requested changes
Feb 11, 2022
packages/app-backend-core/src/app.ts
Outdated
| @@ -142,7 +142,7 @@ export function getAppRecordId (app, defaultId?: string): string { | |||
| while (appIds.has(`${defaultId}:${count}`)) { | |||
There was a problem hiding this comment.
It should be changed here instead
Akryum
changed the title
This fixes a bug where more than two components with the same name could not be held apart by the backend. It is looking for `defaultId:count` while counting references but then names the reference `defaultId_count` this resulted in a maximum of two components with the same name being recognized (that is clickable) in the devtools.
|
Hope I got you right and you want |
|
Yes because now |
Akryum
approved these changes
Feb 11, 2022
|
Thanks for the merge, greatly appreciated 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where more than two components with the same name could not be held apart by the backend. It is looking for
defaultId:countwhile counting references but then names the referencedefaultId_countthis resulted in a maximum of two components with the same name being recognized (that is clickable) in the devtools.