Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: shift + click to expand all child components #1752

Merged
merged 10 commits into from Sep 24, 2022

Conversation

konpeki622
Copy link
Contributor

@konpeki622 konpeki622 commented Feb 21, 2022

closes #1739

force update: merged forceToggleAll to toggle

const isOpen = value === undefined ? !isExpanded.value : value
setComponentOpen(treeNode.id, isOpen)
if (isComponentOpen(treeNode.id)) {
requestComponentTree(treeNode.id)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would also need to expand the nodes that are loaded after that (recursively).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added property autoOpen to TreeNode to resolve it.

@Akryum
Copy link
Member

Akryum commented Mar 10, 2022

Would you mind allowing us to push changes to your branch?

@konpeki622
Copy link
Contributor Author

@Akryum That's ok.

@Akryum
Copy link
Member

Akryum commented Mar 10, 2022

I mean I don't think we technically have the necessary rights to be able to push to this branch.

@konpeki622
Copy link
Contributor Author

I have checked allowing edits. Still can not push to it?👀

@Akryum
Copy link
Member

Akryum commented Mar 10, 2022

Let me try again

@Akryum
Copy link
Member

Akryum commented Mar 10, 2022

Great it works :) Sorry for the messages, was probably me screwing something up 🤷‍♂️

@Akryum Akryum changed the title feat: alt-click to expand all sub-nodes feat: shift + click to expand all child components Sep 24, 2022
@Akryum Akryum merged commit a054381 into vuejs:main Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

alt-click to recursively expand component tree
2 participants