Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firefox): stop extension unloading, fix #1974 #2000

Merged
merged 1 commit into from Jan 20, 2023

Conversation

dmke
Copy link
Contributor

@dmke dmke commented Dec 5, 2022

Description

Firefox starting with version 106 introduced a change which apparently broke background pages. For the Vuejs devtools, this surfaced as extension unloading when the browser reached an "idle" state. User having the extension open noticed it as a unloading/reloading of the devtools tab.

By setting background.persisted to true in the manifest.json, the unloading stopped.

Note: This is a temporary solution, until Manifest v3 is properly supported.

Additional context

#1974


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

Firefox starting with version 106 introduced a change which
apparently broke background pages. For the Vuejs devtools, this
surfaced as extension unloading when the browser reached an
"idle" state. User having the extension open noticed it as
a unloading/reloading of the devtools tab.

By setting background.persisted to true in the manifest.json,
the unloading stopped.

Note: This is a temporary solution, until Manifest v3 is
properly supported.
@dmke
Copy link
Contributor Author

dmke commented Dec 5, 2022

Note: somebody should test this with a Chromium-based browser, I did only care for Firefox.

@dmke
Copy link
Contributor Author

dmke commented Dec 22, 2022

I can confirm that Chrome 108 works as well.

@GuzlejM
Copy link

GuzlejM commented Dec 22, 2022

Hello, good to hear that you have even tested it on Chrome ! :)

Please could you give me some instructions how to apply the changes and where ?

whats before /packages/ path

@dmke
Copy link
Contributor Author

dmke commented Dec 22, 2022

Please could you give me some instructions how to apply the changes and where ?

Follow https://devtools.vuejs.org/guide/contributing.html, either "Testing as Chrome addon" or "Testing as Firefox addon".

In the step "Clone this repo", use my fork instead (git clone https://github.com/dmke/vuejs-devtools --branch fix/1974-unloading).

You can find a pre-built Firefox extension here: #1974 (comment)

Copy link

@djpowers djpowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and tested using the pre-built Firefox extension mentioned in #1974 (comment), and can confirm this resolves the problem I was having.

I also tested it in Google Chrome. Though I was not seeing the reported bug in Chrome, installing the dev build from @dmke's branch per the instructions seemed to function without issue.

Wondering if @Akryum or someone with commit permissions could take a look. Thank you!

@jbhamilton
Copy link

Any idea when this will release?

@Akryum Akryum changed the title fix(chrome): stop extension unloading in Firefox, fix #1974 fix(firefox): stop extension unloading, fix #1974 Jan 20, 2023
@Akryum Akryum merged commit ab5623a into vuejs:main Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants