Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Causes Firefox to not display XML tree #438

Closed
jmsfwk opened this issue Oct 23, 2017 · 9 comments
Closed

Causes Firefox to not display XML tree #438

jmsfwk opened this issue Oct 23, 2017 · 9 comments
Labels

Comments

@jmsfwk
Copy link

jmsfwk commented Oct 23, 2017

When reading a plain XML file Firefox displays the XML tree.

When vue-devtools is enabled it only shows the text nodes.

@posva posva added the bug label Oct 23, 2017
@jpicton
Copy link

jpicton commented Oct 26, 2017

Well that explains it. Been trying to figure out which one of my Firefox addons was disrupting the XML tree view.

@yyx990803
Copy link
Member

@clarkbw would you be able to look into this or point us to someone that might know what's going on?

@clarkbw
Copy link
Contributor

clarkbw commented Nov 8, 2017

I’ve seen this before I think. Something about the detection breaks the XML view. @digitarald might know more about how to track this down.

@digitarald
Copy link

I am asking around, hopefully got somebody to check this tomorrow.

@rpl
Copy link

rpl commented Nov 13, 2017

@digitarald I looks that this issue has been already fixed in #385 by checking if the document is instanceof HTMLDocument before injecting a tag script into the document:

https://github.com/vuejs/vue-devtools/blob/472f3c67200bd70853bc5a93c401cbe9b46fc00f/shells/chrome/src/detector.js#L31-L36

I build the extension from this repo master branch and I confirm that, with the above fix, the XML viewer is rendered as expected on XML documents loaded into Firefox.

The version of vue-devtools on AMO doesn't include this fix yet.

@prog-rajkamal
Copy link

As this issue is already fixed. any idea how soon can we expect an updated version of Vuejs devtools on AMO?

@prog-rajkamal
Copy link

prog-rajkamal commented Jan 6, 2018

It seems @yyx990803 has updated the extension. The issue no longer occurs. So this issue can now be closed.

Verified this on FF 56.

@Akryum Akryum closed this as completed Jan 6, 2018
@yyx990803
Copy link
Member

Lol double close!

@Akryum
Copy link
Member

Akryum commented Jan 6, 2018

😹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

9 participants