Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorrect unit for group duration #1837

Open
dreambo8563 opened this issue Apr 14, 2022 · 0 comments
Open

incorrect unit for group duration #1837

dreambo8563 opened this issue Apr 14, 2022 · 0 comments
Labels
bug

Comments

@dreambo8563
Copy link

dreambo8563 commented Apr 14, 2022 •
edited

Version

6.1.4

Browser and OS info

Chrome 100 / Mac OS

Steps to reproduce

  1. select Timeline tab
  2. select Performance layer
  3. select one event on right panel
  4. group duration shown on right

What is expected?

should be ms

What is actually happening?

current value is 1000 times than real number

image

Mybe should /1000 here ?

devtools/packages/app-frontend/src/features/timeline/TimelineEventInspector.vue

Line 124 in bc6fc1d

display: `${inspectedEvent.group.duration} ms`

@Akryum Akryum added the bug label Apr 14, 2022
@Akryum Akryum changed the title [Bug] incorrect unit for group duration incorrect unit for group duration Apr 14, 2022
DomeT99 added a commit to DomeT99/devtools that referenced this issue May 12, 2023
@DomeT99
fix: incorrect unit for group duration (fix issue vuejs#1837)
ac2245e
@DomeT99 DomeT99 mentioned this issue May 12, 2023
Merged
8 tasks
Akryum pushed a commit that referenced this issue Feb 4, 2024
@DomeT99
fix(timeline): incorrect unit for group duration (fix issue #1837) (#…
a0e906c 
…2067)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Akryum @dreambo8563