fix(vue3): prevent mixin leakage caused by inspection, fix #2037 #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehni
changed the title
lehni
force-pushed
the
fix/inspection-mixin-leak
branch
2 times, most recently
from
2367bce
to
32baa7d
Compare
himself65
reviewed
Apr 11, 2023
|
@himself65 I've accepted your change. CircleCI fails, I don't understand why. |
|
What can we do to get this merged? |
Co-authored-by: Himself65 <himself65@outlook.com>
lehni
force-pushed
the
fix/inspection-mixin-leak
branch
from
8339606
to
a4a5602
Compare
|
@yyx990803 pinging you again on this. This is save to merge, and it's a pretty bad bug, see #2037 |
|
Any ETA on this? This bug causes a huge mess in the large Vue app when global mixin is involved and computed keys being leaked into child components. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #2037 for description. I have tested this on Chrome and it works as expected.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).