Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(electron): chunk message data #2053

Merged

Conversation

nicDamours
Copy link
Contributor

Description

Added chunking to bridge send function, in the electron shell backend, to prevent crash when sending very large payload.
Added chunk function, in utils, based on Andrei R answer on stackoverflow.

Additional context

Socket.io's size limit is 1 mb. When sending a payload larger than that, the socket connection would hang up on it's own and the devtools would be disconnected.

This PR could potentially fix many crashing issue when working with large projects. Some related issues are:

However, this fix is only applied on the standalone electron app. This is why I am not referencing this PR as a direct fix for those issues.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

Added chunking to bridge `send` function, in the electron shell backend, to prevent crash when sending very large payload.
@nicDamours nicDamours changed the title fix(dev): chunk message data fix(electron): chunk message data Apr 17, 2023
@Akryum Akryum merged commit e275579 into vuejs:main Feb 4, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants