Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(component): filtering components of third-party libraries to script(other) #2082

Merged
merged 1 commit into from Feb 4, 2024

Conversation

KaevN
Copy link
Contributor

@KaevN KaevN commented Jun 29, 2023

Description

Problem: if you use third-party ui libraries, the instance of the used components gets into the "setup" block and is mixed with the instance of your component, which is very annoying.
bad

Solution: Added check for component and redirect components to "script(other)" block
good

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

@KaevN
Copy link
Contributor Author

KaevN commented Oct 18, 2023

@Akryum Hello. will it be possible to add this to the next release? instance of components of third-party libraries is very disturbing in the setup block. The screenshots show an example of when you use Ant Design Vue components. Or write if you have any comments or problems with this change

@Akryum Akryum changed the title fix(backend): filtering components of third-party libraries to script(other) fix(component): filtering components of third-party libraries to script(other) Feb 4, 2024
@Akryum Akryum merged commit dbea1f0 into vuejs:main Feb 4, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants