Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue2): Vuex: trim namespace for getter's path if it is not namespaced #2096

Merged
merged 2 commits into from Feb 4, 2024

Conversation

Azurewarth0920
Copy link
Contributor

@Azurewarth0920 Azurewarth0920 commented Aug 17, 2023

Description

fix: #2031
When calculating the path of the getters, the non-namespaced should be trimmed.
This PR will trim the path properly

Eg.

  • ParentModule (non-namespaced)
    • ChildModule (name-spaced)

The path as is: ParentModule/ChildModule/
The path to be: ChildModule/

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

@Akryum Akryum changed the title fix(backend-vue2): Trim namespace for getter's path if it is not namespaced fix(vue2): Vuex: trim namespace for getter's path if it is not namespaced Feb 4, 2024
@Akryum Akryum merged commit a1f8221 into vuejs:main Feb 4, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An error occurred in hook 'getInspectorState' registered by plugin 'org.vuejs.vue2-internal' with payload
2 participants