Scroll to component button #478
Conversation
| @@ -587,7 +591,7 @@ function processObservables (instance) { | |||
| function scrollIntoView (instance) { | |||
| const rect = getInstanceRect(instance) | |||
| if (rect) { | |||
| window.scrollBy(0, rect.top) | |||
| window.scrollBy(0, rect.top + (rect.height - window.innerHeight) / 2) | |||
There was a problem hiding this comment.
making it appear in the middle of the screen is pretty neat actually, It did bother me sometimes (toolbars haha) when it scrolls to the very top
There was a problem hiding this comment.
haha it's exactly why I came across this because clicking on a component makes it auto scroll to the top (and behind my fixed navigation).
Not sure how to change this though (and I feel like it's a new change?)
There was a problem hiding this comment.
Not sure how to change this though (and I feel like it's a new change?)
What do you mean? 😕
There was a problem hiding this comment.
We have a component that's often taller then the screen, so when it scrolls to the middle, it's a bit odd. It would be good to scroll to middle for smaller components, but scroll to top for components taller than the screen height.
Fix #235