Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A prop naming 'disabled' will be parsed into disabled=disabled #182

Closed
airyland opened this issue Mar 22, 2016 · 2 comments
Closed

A prop naming 'disabled' will be parsed into disabled=disabled #182

airyland opened this issue Mar 22, 2016 · 2 comments

Comments

@airyland
Copy link

That brings a problem that I have to use my component like this:

<my-component :disabled=true></my-component>

instead of:

<my-component disabled></my-component>

The problem comes from the dependency: html-minifier

https://github.com/kangax/html-minifier/blob/gh-pages/src/htmlparser.js#L84

So anyway to fix this or do I have to use another prop name?


Another problem, the disabled prop is defined like this:

{
 type: Boolean,
 default: false
}

So even the raw value is "disabled", it should be coerced to True?

@yyx990803
Copy link
Member

This is now fixed in Vue core: vuejs/vue@c915cf4

@airyland
Copy link
Author

Cool. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants