Feat: update to Typescript 3.9 #1106
Conversation
# Conflicts: # packages/runtime-core/src/apiDefineComponent.ts
|
We may not need to create |
|
That's great! will try that out and update this :) Thanks! |
This reverts commit 11cd53d. # Conflicts: # packages/runtime-core/src/apiDefineComponent.ts
|
@pikax can you resolve the conflict in the lockfile? |
# Conflicts: # yarn.lock
# Conflicts: # yarn.lock
| @@ -129,7 +130,7 @@ describe('with object props', () => { | |||
| expectType<ExpectedProps['eee']>(this.eee) | |||
| expectType<ExpectedProps['fff']>(this.fff) | |||
|
|
|||
| // props on `this` should be readonly | |||
| // @ts-expect-error props on `this` should be readonly | |||
| expectError((this.a = 1)) | |||
There was a problem hiding this comment.
is expectError necessery here? maybe it's enough to do
// @ts-expect-error props on `this` should be readonly
this.a = 1?
There was a problem hiding this comment.
I kept the expectError to keep the same interface as before, felt a bit better to me, is not necessary to have it
| @@ -0,0 +1,10 @@ | |||
| { | |||
There was a problem hiding this comment.
Why do we need this build config? (What are we testing with this?)
There was a problem hiding this comment.
This tests the output files, to make sure our output typings are correct. Because of the usage of @internal we might hide some apis, using this config will make the dependencies to resolve to the publish dirs instead of the src code
|
Will merge first thing next week! |
Typescript 3.9.2 is currently breaking some types on
defineComponentThis PR aims to fix those errors and also remove the need of TSD.
Closes #1106