Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSR Usage in non-Node.js Environments no longer works #3467

Closed
ferdinando-ferreira opened this issue Mar 23, 2021 · 1 comment
Closed

SSR Usage in non-Node.js Environments no longer works #3467

ferdinando-ferreira opened this issue Mar 23, 2021 · 1 comment
Labels
scope: ssr ✨ feature request New feature or request

Comments

@ferdinando-ferreira
Copy link

Version

3.0.7

Reproduction link

https://github.com/ferdinando-ferreira/vue-next

Steps to reproduce

The full description of the issue (plus a fix for the issue) was submitted as a PR at #3460.

Here is the short summary

git clone git@github.com:ferdinando-ferreira/vue-next.git --single-branch vue-next-basic-renderer
cd vue-next-basic-renderer
yarn
yarn build
cd usecase
npm install
npm run build
npm run start:phpv8-current

It depends on php and phpv8 extension.

What is expected?

An example similar to what is described at https://ssr.vuejs.org/guide/non-node.html working as described

What is actually happening?

With the addition of renderToStream on server-renderer it is no longer possible to compile a SSR version for non Node environments


Submitted a PR (#3460) that fixes the issue

@frandiox
Copy link

I'm also having issue with stream dependency. The thing is, I'm only importing renderToString, not renderToStream but, since the production build of @vue/server-renderer is CJS, Rollup cannot do the tree shake.
Perhaps just providing an ESM build could work?

@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: ssr ✨ feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants