Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(reactivity): unwrap nested ref #180

Merged
merged 2 commits into from Oct 10, 2019
Merged

feat(reactivity): unwrap nested ref #180

merged 2 commits into from Oct 10, 2019

Conversation

wuomzfx
Copy link
Contributor

@wuomzfx wuomzfx commented Oct 10, 2019 

const a = ref(0)
const b = ref(a)

expect(typeof (b.value + 1)).toBe('number') // rather than b.value.value

This seems more reasonable

himself65
himself65 suggested changes Oct 10, 2019
View reviewed changes
packages/reactivity/src/ref.ts Outdated Show resolved Hide resolved
yyx990803
yyx990803 requested changes Oct 10, 2019
View reviewed changes
packages/reactivity/src/reactive.ts Outdated Show resolved Hide resolved
@yyx990803 yyx990803 merged commit cbb4b19 into vuejs:master Oct 10, 2019
@vue-bot
Copy link

vue-bot commented Oct 10, 2019

Hey @wuomzfx, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yyx990803 yyx990803 yyx990803 requested changes

@himself65 himself65 himself65 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wuomzfx @vue-bot @yyx990803 @himself65