fix(runtime-core): bind default function of inject to instance (fix #3923) #3925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eunjae-lee
commented
Jun 9, 2021
| } | ||
| }, | ||
| render() { | ||
| // @ts-ignore |
There was a problem hiding this comment.
I don't know how to make this work without this ts-ignore. Any idea?
eunjae-lee
added a commit
to algolia/vue-instantsearch
that referenced
this pull request
Jun 24, 2021
This reverts commit cf7f20a, because the issue has been fixed since Vue@3.1.2 by vuejs/core#3925
Haroenv
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Dec 28, 2022
…instantsearch#951)" This reverts commit 8348d3d, because the issue has been fixed since Vue@3.1.2 by vuejs/core#3925
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the issue #3923.
I added a regression test. I'm not familiar with this code base especially how you normally type things.
Let me know if you need me to modify anything.