test: add test for runtime-dom/modules/class #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sodatea
commented
Sep 30, 2019
yyx990803
reviewed
Oct 1, 2019
| ]) | ||
| }) | ||
|
|
||
| test('class merge between parent and child', () => { |
There was a problem hiding this comment.
This one is failing because the new attr fallthrough behavior in v3: vuejs/rfcs#26
There is no longer automatic class merging and the child now needs to explicitly merge parent props.
sodatea
commented
Nov 15, 2019
| expect(root.children[0].className).toBe('c d a b') | ||
|
|
||
| render(h(parent), root) | ||
| expect(root.children[0].className).toBe('c d a b') |
There was a problem hiding this comment.
The only difference between the 2 cases is that child2 has an empty props declaration, therefore it successfully triggered class merging while the other one didn't.
I didn't see anything about this behavior in the inheritAttrs RFS.
Seems a bug in the current implementation?
@yyx990803
yyx990803
force-pushed
the
test-dom-class
branch
from
0997235
to
a4148c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.