Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add warning to readonly property assign attempt #81

Closed
wants to merge 2 commits into from
Closed

fix: Add warning to readonly property assign attempt #81

wants to merge 2 commits into from

Conversation

ant1m4tt3r
Copy link

No description provided.

@TimvdEijnden TimvdEijnden mentioned this pull request Oct 4, 2019
Merged
znck
znck reviewed Oct 5, 2019
View reviewed changes
Copy link
Member

@znck znck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should provide some context where the property is assigned. The filename and source location can help mitigate this situation easily.

@ant1m4tt3r
Copy link
Author

ant1m4tt3r commented Oct 5, 2019 via email •
edited

@znck znck added the need guidance The approach/solution in the PR is unclear and requires guidance from maintainer to proceed further. label Oct 5, 2019
@TimvdEijnden
Copy link
Contributor

@hugoazevedosoares You can get some inspiration from my PR about other warnings: #82 😉

@ant1m4tt3r
Copy link
Author

@hugoazevedosoares You can get some inspiration from my PR about other warnings: #82

Thanks @TimvdEijnden , but I could not find the context of the property change in this function. Do you have any idea how can I get this data?

@TimvdEijnden
Copy link
Contributor

@hugoazevedosoares If you know the name of the property that might be enough. If I would find out how to get the name I would just create a test and debug the code.

@HcySunYang
Copy link
Member

Hi, thanks for this PR, but it is stale so close it now

@HcySunYang HcySunYang closed this Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@znck znck znck left review comments

Assignees
No one assigned
Labels
need guidance The approach/solution in the PR is unclear and requires guidance from maintainer to proceed further.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ant1m4tt3r @TimvdEijnden @HcySunYang @znck