Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test for route not matched #279

Merged
merged 5 commits into from
May 29, 2020
Merged

test: add test for route not matched #279

merged 5 commits into from
May 29, 2020

Conversation

pikax
Copy link
Member

@pikax pikax commented May 29, 2020

Warns when the route is not found

posva
posva requested changes May 29, 2020
View reviewed changes
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change the warning message to

No match found for location with path "${path}".

__tests__/warnings.spec.ts Outdated Show resolved Hide resolved
__tests__/warnings.spec.ts Outdated Show resolved Hide resolved
__tests__/warnings.spec.ts Outdated Show resolved Hide resolved
src/router.ts Outdated Show resolved Hide resolved
src/router.ts Outdated Show resolved Hide resolved
posva
posva approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work and thanks!

@posva posva merged commit d125356 into vuejs:master May 29, 2020
@pikax pikax deleted the test/warn_when_not_matched branch May 29, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva posva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pikax @posva