Improve Vetur component data #408
Conversation
vetur/tags.json
Outdated
| @@ -1,10 +1,10 @@ | |||
| { | |||
| "router-view": { | |||
| "attributes": ["name", "route"], | |||
| "description": "Component that renders the matched component for the current location. Components rendered by `<router-view>` can also contain their own `<router-view>` to render nested routes." | |||
| "description": "Component that renders the matched component for the current location. Components rendered by `<router-view>` can also contain their own `<router-view>` to render nested routes.\n\n[API Reference](https://router.vuejs.org/api/#router-link)" | |||
| }, | |||
| "router-link": { | |||
| "attributes": ["to", "activeClass","exactActiveClass", "custom"], | |||
There was a problem hiding this comment.
Why are you not including all attributes for router-link?
There was a problem hiding this comment.
I forgot ariaCurrentValue because I added it later I think
There was a problem hiding this comment.
all the other props have been removed
There was a problem hiding this comment.
🤦♂️ I was comparing it against old Vue router docs. Do you have a new one available? Can't find it. Also if they would be in different sites I should link to the one for vue-router-next.
(BTW I wasn't aware, are all attributes renamed to camelCase?)
There was a problem hiding this comment.
There isn't an official link yet, so I think we can add that later.
props can be passed both ways but by what you are saying I understand I should provide the kebab-case version for autocompletion 😄
There was a problem hiding this comment.
@posva I can add functionality to handle camelCase to kebab-case as well. No worries, just need to do a bit of changes in Vetur side.
There was a problem hiding this comment.
I think autocompleting on kebab-case is the way to go because it works on different contexts whereas camelCase doesn't. We should just use kebab-case in these files
Do you mean that because we don't have a new site for vue-router-next yet, so we shouldn't link them anyway? |
|
yes, because we don't have the right links so pointing to outdated ones could be confusing |
octref
force-pushed
the
vetur-component-data
branch
from
4edaa86
to
7da4595
Compare
|
I didn't notice the contributing guideline. I squashed and gave a new commit message. |
|
@posva That's up to you — anytime you want. Thanks for reviewing 👍 |
No description provided.