Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(guards): vue-class-component call guards on first... #755

Merged
merged 1 commit into from
Feb 4, 2021
Merged

fix(guards): vue-class-component call guards on first... #755

merged 1 commit into from
Feb 4, 2021

Conversation

ygj6
Copy link
Member

@ygj6 ygj6 commented Feb 4, 2021

close #739

posva
posva approved these changes Feb 4, 2021
View reviewed changes
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@posva posva changed the title fix(guards): guard function not called for vue-class-component fix(guards): vue-class-component call guards on first... Feb 4, 2021
@posva posva merged commit 06f942d into vuejs:master Feb 4, 2021
@websmurf
Copy link

websmurf commented Feb 5, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva posva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BeforeRouteEnter event not called for async loaded components
3 participants
@ygj6 @websmurf @posva