Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better v-on '@' shorthand match #206

Closed
wants to merge 2 commits into from
Closed

Better v-on '@' shorthand match #206

wants to merge 2 commits into from

Conversation

dsl101
Copy link

@dsl101 dsl101 commented Feb 2, 2021

Support v-on shorthand with event handlers containing colon (e.g. @hook:mounted="onChildMounted")

I'm not 100% certain, but I think the matching should be the same as for regular v-* at line 663. Potentially fixes #203. Tested locally for that scenario, but I'm not sure if there are other directives which might be affected by this.

Support v-on shorthand with event handlers containing colon.
@rchl
Copy link

rchl commented Feb 2, 2021

I'm not sure about the change itself but you haven't followed the development instructions. See https://github.com/vuejs/vue-syntax-highlight/tree/new#development

Applied the same change to the .yaml-macros file
@dsl101
Copy link
Author

dsl101 commented Feb 2, 2021

Oops—missed that. Sorry :).

@FichteFoll
Copy link

Should be fixed/handled by #216.

@dsl101 dsl101 closed this Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants