fix: wrapper.setSelected() to work on select with optgroups (#715)

vuejs · Jun 14, 2018 · dae0b1c · dae0b1c
1 parent 93b8d98
commit dae0b1c
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 1 deletion.
diff --git a/packages/test-utils/src/wrapper.js b/packages/test-utils/src/wrapper.js
@@ -642,7 +642,13 @@ export default class Wrapper implements BaseWrapper {
       // $FlowIgnore
       el.selected = true
       // $FlowIgnore
-      createWrapper(el.parentElement, this.options).trigger(event)
+      if (el.parentElement.tagName === 'OPTGROUP') {
+        // $FlowIgnore
+        createWrapper(el.parentElement.parentElement, this.options).trigger(event)
+      } else {
+        // $FlowIgnore
+        createWrapper(el.parentElement, this.options).trigger(event)
+      }
     } else if (tag === 'SELECT') {
       throwError('wrapper.setSelected() cannot be called on select. Call it on one of its options')
     } else if (tag === 'INPUT' && type === 'checkbox') {

diff --git a/test/resources/components/component-with-input.vue b/test/resources/components/component-with-input.vue
@@ -9,6 +9,15 @@
       <option value="selectB"></option>
       <option value="selectC"></option>
     </select>
+    <select v-model="selectVal" class="with-optgroups">
+      <optgroup label="Group1">
+        <option value="selectA"></option>
+        <option value="selectB"></option>
+      </optgroup>
+      <optgroup label="Group2">
+        <option value="selectC"></option>
+      </optgroup>
+    </select>
     <label id="label-el"></label>
 
     <span class="checkboxResult" v-if="checkboxVal">checkbox checked</span>

diff --git a/test/specs/wrapper/setSelected.spec.js b/test/specs/wrapper/setSelected.spec.js
@@ -22,6 +22,17 @@ describeWithShallowAndMount('setSelected', (mountingMethod) => {
     expect(wrapper.text()).to.contain('selectA')
   })
 
+  it('updates dom with select v-model for select with optgroups', () => {
+    const wrapper = mountingMethod(ComponentWithInput)
+    const options = wrapper.find('select.with-optgroups').findAll('option')
+
+    options.at(1).setSelected()
+    expect(wrapper.text()).to.contain('selectB')
+
+    options.at(0).setSelected()
+    expect(wrapper.text()).to.contain('selectA')
+  })
+
   it('throws error if wrapper does not contain element', () => {
     const wrapper = mountingMethod({ render: (h) => h('div') })
     const div = wrapper.find('div')