Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Please improve the Documentation #22

Closed
AllTheGoodOnesWereTaken opened this issue Jul 21, 2018 · 1 comment
Closed

[Request] Please improve the Documentation #22

AllTheGoodOnesWereTaken opened this issue Jul 21, 2018 · 1 comment

Comments

@AllTheGoodOnesWereTaken
Copy link

AllTheGoodOnesWereTaken commented Jul 21, 2018

At this point the documentation on this version is extremely poor compared to the original custom-elements package, so i see no reason to switch to this version just yet.
It's important to note exactly which Browsers you support and which you tested this on, and we need more code examples and tutorials on how to set this all up properly, how to access our data if we need it, things like that.

Would also be nice to see how this implementation performs when compared to React Fiber & StencilJS using an implementation of their common performance demo :)

https://stencil-fiber-demo.firebaseapp.com/perf.html

@yyx990803
Copy link
Member

  1. This is not meant as a replacement of the "original", you can keep using that if you find it suit your use case better. The usage is simple enough and I don't think extra documentation is really necessary, but I'm open to PRs.

  2. That performance demo has nothing to do with web components. It's a demo about vdom diffing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants