Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v-on): add removing all dom event listeners when vnode destroyed #10085

Merged
merged 1 commit into from
Aug 5, 2021

Conversation

zrh122
Copy link
Contributor

@zrh122 zrh122 commented May 29, 2019

Add removing all dom event listeners when vnode destroyed
fixes #10083
fixes #10004

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@clopezcapo
Copy link

clopezcapo commented Jul 1, 2019

Do you know if this also happens in the PROD version? As I am not able to filter by "vue" components in Chrome DevTools. I see the same code as the dev version though...

@novakjcn
Copy link

Hi all,
I can confirm this fixes the memory leak problem in our app. We have some quite large Vue components so this issue is actually crashing our app after typing inside inputs and reopening some modal windows for example.
Is this planned to be released?
Thanks a lot :)

@momodiy
Copy link

momodiy commented Jul 20, 2020

I'm sure this is useful

@suneab
Copy link

suneab commented Oct 7, 2020

Is this planned for release? We are still patching this in our solution

@aka434112
Copy link

@posva, could you please let us know by when this fix would be made available?

@songguangyu
Copy link

@posva same facing this problem, when this fix would be made available?

@SijieCai
Copy link

I have waited for this pr and patch fix for a long time, could somebody merge or give some explanation if there are other concern or risk for the pending.

@JinPengGeng
Copy link

any update for this PR?

@suneab
Copy link

suneab commented Nov 24, 2020

Still waiting :)

can-keklik added a commit to can-keklik/countly-server that referenced this pull request Feb 10, 2021
@posva posva added this to Reviewed once, needs another review in 2.6.13 Mar 24, 2021
@posva posva added this to Planned in 2.6.15 via automation Jun 1, 2021
@posva posva moved this from Planned to Reviewed once, needs another review in 2.6.15 Jun 1, 2021
@ygj6
Copy link
Member

ygj6 commented Aug 5, 2021

Hi @posva, my team also encountered this problem. And I have tested this patch, it works!

@posva posva merged commit 3d29ba8 into vuejs:dev Aug 5, 2021
2.6.15 automation moved this from Reviewed once, needs another review to Done Aug 5, 2021
@ota-meshi ota-meshi mentioned this pull request Dec 20, 2021
@lidaining-web
Copy link

When will it be released?

@JhonWeawer
Copy link

Can anyone tell me when this fix will be released?and why so long? 🙂

@kdydesign
Copy link

kdydesign commented Apr 4, 2022

Has it been released? 2.6.15 Please let me know the release schedule.

@leealso
Copy link

leealso commented Sep 2, 2022

Anything on this one?

@v1talii-dev
Copy link

when is the release expected?

@mae-financial-com
Copy link

Is this available if we use the ^2.7.0 version or in which version to find this fix?

@boy-liutao
Copy link

I would like to know when 2.6.15 will be released

@zongzi531
Copy link

Awesome!!! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2.6.13
Reviewed once, needs another review